TypeOrmHealthIndicator pingCheck is not working for mongo

[vladimirhinic]

I'm submitting a...

[ ] Regression 
[x ] Bug report
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead post your question on Stack Overflow.

Current behavior

TypeOrmHealthIndicator pingCheck is calling 'select 1' which will not work for Mongo.

Expected behavior

TypeOrmHealthIndicator pingCheck should work for mongo

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment

Nest version: X.Y.Z

 6.2.0

For Tooling issues:
- Node version: XX  
- Platform:  

Others:

[BrunnerLivio]

To check a MongoDB connection you should use the MongooseHealthIndicator.
mongoose.pingCheck('mongo')

See sample

TypeOrm is only for SQL databases.

[vladimirhinic]

@BrunnerLivio thanks for you reply. I do not feel I should have to include mongoose to my project just to be able to do health check. I user TypeORM for mongo, and I want to use same for health check. At the moment, I use customs check, but I feel strongly that TypeORM health indicator should handle mongo or sql check without any issues.

[BrunnerLivio]

@vladimirhinic

I user TypeORM for mongo
Are you sure? Maybe recheck if you are actually using MongoDB as database because I am 100% sure MongoDB is not compatible with TypeORM.

From TypeORMs description:

ORM for TypeScript and JavaScript (ES7, ES6, ES5). Supports MySQL, PostgreSQL, MariaDB, SQLite, MS SQL Server, Oracle, WebSQL databases.

So it only works with SQL databases whereas MongoDB is a non-SQL database. Mongoose is the official and best client for MongoDB operations.

Maybe you should have a look again at SQL / non-SQL databases and their respective clients (TypeORM, Mongoose)?

[vladimirhinic]

Yes, I'm sure. Check TypeORM home page and search for Mongo. Also check example https://github.com/nestjs/nest/tree/master/sample/13-mongo-typeorm

[BrunnerLivio]

@vladimirhinic Oh wow, sorry for disbelieving you!

I think I gotta ask TypeOrm to update their docs so others are not confused as I was. Will look into it :)

[vladimirhinic]

No, problems... it is a bit buried on their page. I'm currently using status() on collection as a health check, but I'm not sure if that is expensive and it is also linked and dependant on particular collection(s).

[tan-dd]

Is there any decision in this thread? is this being added?