Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(): fix clonePrimitiveLiteral result is undefined issue on Length decorator #2760

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

cantecim
Copy link
Contributor

@cantecim cantecim commented Dec 26, 2023

  • fixes an issue adding minLength and maxLength properties when using Length with an expression

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

plugin unable to add minLength and maxLength properties when @Length decorator used with an expression

What is the new behavior?

plugin is now able to add minLength and maxLength properties even when @Length decorator used with an expression

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

* fixes an issue adding minLength and maxLength properties when using Length with an expression
@cantecim cantecim marked this pull request as ready for review December 26, 2023 17:12
@cantecim cantecim changed the title fix(): fix clonePrimitiveLiteral is undefined issue on Length decorator fix(): fix clonePrimitiveLiteral result is undefined issue on Length decorator Dec 27, 2023
@kamilmysliwiec kamilmysliwiec merged commit 1fb1995 into nestjs:master Jan 15, 2024
1 check passed
@kamilmysliwiec
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants