fix(fastify): append headers instead of overwriting - #17566
Open
bun-unsafe wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
AbstractHttpAdapter.appendHeader/ExpressAdapter.appendHeaderappend a header value (response.append).FastifyAdapter.appendHeadercalls Fastifyreply.header(), which replaces any existing value except forset-cookie.Calling
appendHeadertwice with the same name (for examplex-a: 1thenx-a: 2) therefore keeps only the last value on Fastify, while Express keeps both.This dates back to the original adapter methods in #12955.
Issue Number: N/A
What is the new behavior?
FastifyAdapter.appendHeaderconcatenates onto the current header when one is already set, matching Express.set-cookiestill goes through Fastifyreply.header()only. Fastify already concatenates that name; passing the accumulated list back intoheader()would duplicate previous cookies.Does this PR introduce a breaking change?
Call sites that used
appendHeaderas a secondsetHeaderon Fastify would start seeing multiple values. That matches the method name andExpressAdapter.Other information
Repro: Fastify adapter,
appendHeader(res, 'x-a', '1')thenappendHeader(res, 'x-a', '2'), thengetHeader(res, 'x-a'). Before:'2'. After:['1', '2'].Tests:
packages/platform-fastify/test/adapters/fastify-adapter.spec.ts(append twice,setHeaderthen append, header name case, three values,set-cookiewithout duplicates).