fix(core): ensure nested transient provider isolation #15815
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When a transient provider depends on another transient provider, each parent consumer should receive its own dedicated instance of the nested transient provider. However, in request/durable scoped contexts, nested transient providers are incorrectly shared across different parents, causing context pollution.
Issue Number: #15689
What is the new behavior?
Each parent now receives its own isolated instance of nested transient providers. The fix adds a
getEffectiveInquirer()helper method that uses parentInquirer instead of inquirer when resolving transient-to-transient dependency chains in non-static contexts (REQUEST/DURABLE scopes).Key changes:
Does this PR introduce a breaking change?
Other information
Similar but distinct from: #15553 / #15571: Lifecycle hook phantom instance bug (different root cause)