Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove unused dev dependencies #13454

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

micalevisk
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: closes #13432

What is the new behavior?

upon running npm i we'll see the following error:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @nestjs/graphql@12.1.1
npm ERR! Found: ts-morph@22.0.0
npm ERR! node_modules/ts-morph
npm ERR!   dev ts-morph@"22.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peerOptional ts-morph@"^16.0.0 || ^17.0.0 || ^18.0.0 || ^19.0.0 || ^20.0.0 || ^21.0.0" from @nestjs/graphql@12.1.1
npm ERR! node_modules/@nestjs/graphql
npm ERR!   dev @nestjs/graphql@"12.1.1" from the root project
npm ERR!   peer @nestjs/graphql@"^12.0.0" from @nestjs/apollo@12.1.0
npm ERR!   node_modules/@nestjs/apollo
npm ERR!     dev @nestjs/apollo@"12.1.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: ts-morph@21.0.1
npm ERR! node_modules/ts-morph
npm ERR!   peerOptional ts-morph@"^16.0.0 || ^17.0.0 || ^18.0.0 || ^19.0.0 || ^20.0.0 || ^21.0.0" from @nestjs/graphql@12.1.1
npm ERR!   node_modules/@nestjs/graphql
npm ERR!     dev @nestjs/graphql@"12.1.1" from the root project
npm ERR!     peer @nestjs/graphql@"^12.0.0" from @nestjs/apollo@12.1.0
npm ERR!     node_modules/@nestjs/apollo
npm ERR!       dev @nestjs/apollo@"12.1.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /home/micael/.npm/_logs/2024-04-16T13_21_01_466Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /home/micael/.npm/_logs/2024-04-16T13_21_01_466Z-debug-0.log

but that's expected because of an outdated version ts-morph on @nestjs/graphl

Does this PR introduce a breaking change?

  • Yes
  • No

@coveralls
Copy link

coveralls commented Apr 16, 2024

Pull Request Test Coverage Report for Build 433cda22-a4d7-4558-a797-9ca8b96cd7ed

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.123%

Totals Coverage Status
Change from base Build e8e3c154-2e4b-4603-8729-3ff01d3ab650: 0.0%
Covered Lines: 6736
Relevant Lines: 7312

💛 - Coveralls

@Tony133
Copy link
Contributor

Tony133 commented Apr 16, 2024

Removing the commitlint-circle package gives this error

screen-error

however the `commitlint-circle' package is used here: https://github.com/nestjs/nest/blob/master/.circleci/config.yml#L134

are you sure it is right to eliminate it ? 😄

@micalevisk
Copy link
Member Author

micalevisk commented Apr 16, 2024

good catch

I think we should remove the commitlint-circle because of this:

image

@kamilmysliwiec kamilmysliwiec merged commit 87cf25a into nestjs:master Apr 18, 2024
5 checks passed
@micalevisk micalevisk deleted the chore/issue-13432 branch April 18, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chore] drop dev. dependencies that are leading to errors on running npm install in this repo
4 participants