Skip to content

Commit

Permalink
Merge pull request #13083 from nestjs/fix/non-unique-hashes
Browse files Browse the repository at this point in the history
fix: generate unique hashes for dynamic modules, and clients
  • Loading branch information
kamilmysliwiec authored Jan 23, 2024
2 parents bfca362 + 9e8f25d commit 829f57f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ export class ConfigurableModuleBuilder<
const providers: Array<Provider> = [
{
provide: self.options.optionsInjectionToken,
useFactory: () => this.omitExtras(options, self.extras),
useValue: this.omitExtras(options, self.extras),
},
];
if (self.options.alwaysTransient) {
Expand Down
3 changes: 1 addition & 2 deletions packages/microservices/module/clients.module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ export class ClientsModule {
const clients = (clientsOptions || []).map(item => {
return {
provide: item.name,
useFactory: () =>
this.assignOnAppShutdownHook(ClientProxyFactory.create(item)),
useValue: this.assignOnAppShutdownHook(ClientProxyFactory.create(item)),
};
});
return {
Expand Down

0 comments on commit 829f57f

Please sign in to comment.