Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix docs asset file paths in /grunt/configBridge.json (twbs#20178)
Previously, when running the docs locally, the site, rooted at: http://localhost:9001/ would reference docs assets using relative URLs such as: /../assets/js/vendor/anchor.min.js which is equivalent to: http://localhost:9001/../assets/js/vendor/anchor.min.js which is nonsense, since the root directory has no parent directory. Apparently browsers silently ignore this extra '..', hence why this wasn't noticed until now. But if you adjust Jekyll's `baseurl` setting, this mistake causes incorrect URLs to get generated. This commit corrects the problem by removing the extra '../' from the paths. These paths are also referenced in the Gruntfile, where the fix actually allows us to simplify the code. Previously, in the Gruntfile, we were doing, e.g.: path.join('./docs/assets', '../assets/js/vendor/anchor.min.js') which calculates to: ./docs/assets/../assets/js/vendor/anchor.min.js which can be simplified to: ./docs/assets/js/vendor/anchor.min.js So we can remove the '/assets' suffix from the left argument and the '../' prefix from the right argument and still obtain the same result.
- Loading branch information