Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #118 and #185, added #106, check for deno.land/x urls in readme, basic auditing #184

Merged
merged 7 commits into from
Jul 2, 2020
Merged

Fixed #118 and #185, added #106, check for deno.land/x urls in readme, basic auditing #184

merged 7 commits into from
Jul 2, 2020

Conversation

martonlederer
Copy link
Member

@martonlederer martonlederer commented Jul 2, 2020 •
edited
Loading

Changes:

@vercel
Copy link

vercel bot commented Jul 2, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/nestlandgh/nest-land/l76s003g0
✅ Preview: https://nest-land-git-fork-martondev-master.nestlandgh.vercel.app

@martonlederer martonlederer changed the title Fixed #118 and added checking for deno.land/x urls in readme [W.I.P] Fixed #118 and added checking for deno.land/x urls in readme, added entry to front-end Jul 2, 2020
@martonlederer martonlederer changed the title [W.I.P] Fixed #118 and added checking for deno.land/x urls in readme, added entry to front-end [W.I.P] Fixed #118 and #185, check for deno.land/x urls in readme, basic auditing Jul 2, 2020
@martonlederer martonlederer changed the title [W.I.P] Fixed #118 and #185, check for deno.land/x urls in readme, basic auditing Fixed #118 and #185, check for deno.land/x urls in readme, basic auditing Jul 2, 2020
@martonlederer
Copy link
Member Author

@tbaumer22 ready for review

t8
t8 requested changes Jul 2, 2020
View reviewed changes
Copy link
Member

@t8 t8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Let's just address what I mentioned and I think we'll be good to merge. Thanks Marton!

web/src/components/package/PackageDetail.vue Outdated Show resolved Hide resolved
web/src/components/package/PackageDetail.vue Outdated Show resolved Hide resolved
@martonlederer
Copy link
Member Author

Resolving what you mentioned, and adding some new small changes too

This was linked to issues Jul 2, 2020
Remove No README warning when there is a REAMDME.md #118
Closed
[BUG] Website says module should be imported from mod.ts, when the entry file is set to mod.js #185
Closed
[BUG] Installation URL not accurate for any file other than mod.ts #67
Closed
@martonlederer martonlederer changed the title Fixed #118 and #185, check for deno.land/x urls in readme, basic auditing Fixed #118 and #185, check for deno.land/x urls in readme, basic auditing, copy entry Jul 2, 2020
@martonlederer martonlederer changed the title Fixed #118 and #185, check for deno.land/x urls in readme, basic auditing, copy entry Fixed #118 and #185, added #106, check for deno.land/x urls in readme, basic auditing Jul 2, 2020
@t8 t8 linked an issue Jul 2, 2020 that may be closed by this pull request
[FEATURE] Copy module URL when clicked #106
Closed
t8
t8 approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@t8 t8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t8 t8 merged commit f97f1c4 into nestdotland:master Jul 2, 2020
@mjrlowe mjrlowe mentioned this pull request Aug 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8 t8 t8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@martonlederer @t8