Skip to content

Port mpitest/test_global_rng from SLI to Python #3630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
heplesser merged 3 commits into from
Nov 12, 2025
Merged

Port mpitest/test_global_rng from SLI to Python #3630

heplesser merged 3 commits into from
Nov 12, 2025

Conversation

@heplesser
Copy link
Contributor

@heplesser heplesser commented Nov 12, 2025

This PR also adds a new MPITestWrapper subclass.

@github-project-automation github-project-automation bot moved this to In progress in PyNEST-NG Nov 12, 2025
otcathatsya
otcathatsya approved these changes Nov 12, 2025
View reviewed changes
Copy link
Contributor

@otcathatsya otcathatsya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have separate tests with a passing + failing case instead of the commented-out part?

@heplesser
Copy link
Contributor Author

heplesser commented Nov 12, 2025

Should we have separate tests with a passing + failing case instead of the commented-out part?

I left this in for situations where a developer of tests wants to test the test system. I'd like to keep it in for now.

@heplesser heplesser merged commit e401a89 into nest:master Nov 12, 2025
29 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in PyNEST-NG Nov 12, 2025
@heplesser heplesser deleted the test_global_rng branch November 12, 2025 12:00
heplesser added a commit to heplesser/nest-simulator that referenced this pull request Nov 20, 2025
@heplesser
Remove test_global_rng.sli to completed nest#3630
75a4c18
@heplesser heplesser mentioned this pull request Nov 20, 2025
Merged
heplesser added a commit that referenced this pull request Nov 20, 2025
@heplesser
Merge pull request #3637 from heplesser/remove_test_global_rng_sli
3fed3bd 
Remove test_global_rng.sli to complete #3630
Helveg pushed a commit to Helveg/nest-simulator that referenced this pull request Nov 30, 2025
@heplesser @gtrensch
@terhorstd @dependabot @janskaar @jessica-mitchell @med-ayssar @pnbabu @JanVogelsang @babsey @mlober @clinssen
Revise 1to2 test (#7)
323cebd 
* remove trailing spaces

* set haveMPI4py to 'False' if NEST was compiled without MPI

* Check that NEST is installed with MPI support and mpi4py is available

* Check that NEST is installed with MPI support and mpi4py is available

* load MPI module

* fix code style violations

* check that NEST is installed with MPI support and mpi4py is available

* check that NEST is installed with MPI support and mpi4py is available

* fix typo in workflow

* revert quoting in github expression syntax

* added diffs from developers without pre-commit

* Bump actions/cache from 4.2.3 to 4.2.4

Bumps [actions/cache](https://github.com/actions/cache) from 4.2.3 to 4.2.4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@5a3ec84...0400d5f)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-version: 4.2.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump actions/checkout from 4.2.2 to 5.0.0

Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.2 to 5.0.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@11bd719...08c6903)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 5.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump github/codeql-action from 3.29.2 to 3.29.9

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.29.2 to 3.29.9.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@181d5ee...df55935)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.29.9
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* add test

* change ampltiude

* black

* black

* black

* flake8

* flake8

* rm original test

* Bump actions/setup-python from 4.7.0 to 5.6.0

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.7.0 to 5.6.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v4.7.0...a26af69)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-version: 5.6.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update testsuite/pytests/sli2py_neurons/test_iaf_psc_exp_ps_lossless.py

Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>

* parameterize test, single file

* improve network model text, add links

* Update doc/htmldoc/models/index.rst

* Bump actions/dependency-review-action from 4.7.1 to 4.7.2

Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 4.7.1 to 4.7.2.
- [Release notes](https://github.com/actions/dependency-review-action/releases)
- [Commits](actions/dependency-review-action@da24556...bc41886)

---
updated-dependencies:
- dependency-name: actions/dependency-review-action
  dependency-version: 4.7.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump github/codeql-action from 3.29.9 to 3.29.10

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.29.9 to 3.29.10.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@df55935...96f518a)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.29.10
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump actions/checkout from 4.1.1 to 5.0.0

Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.1 to 5.0.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4.1.1...08c6903)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 5.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* remove Potjans from examples

* update links, add intersphinx to pd14

* update network index page

* Bump github/codeql-action from 3.29.10 to 3.29.11

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.29.10 to 3.29.11.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@96f518a...3c3833e)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 3.29.11
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Properly delete proxy nodes on finalization.

* Use unique_ptr to pass SecondaryEvents to functions to avoid memory leaks.

Co-authored-by: med-ayssar <med.ayssar@gmail.com>

* Update-cycle monitoring now thread-safe

* Ensure that testsuite detects missing test results

* Ensure all found tests are run and phases with zero results detected

* Detect missing tests based on hard-coded minimal numbers

* Temporarily show summary invocation

* Fix bugs in shell code

* Adjust required test counts to account for missing python and missing threads

* Fix typo.

Co-authored-by: Pooja Babu <75320801+pnbabu@users.noreply.github.com>

* Fix indentation

* Temporarily active debug output for Music tests

* Remove quotes that broke musictests

* Remove debug output and add comment

* Bump step-security/harden-runner from 2.13.0 to 2.13.1

Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.13.0 to 2.13.1.
- [Release notes](https://github.com/step-security/harden-runner/releases)
- [Commits](step-security/harden-runner@ec9f2d5...f4a75cf)

---
updated-dependencies:
- dependency-name: step-security/harden-runner
  dependency-version: 2.13.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Add doxygen comment for method.

* Backport atomic from pynest-ng to avoid data race

* Move update of thread-local node data out of set_target() and into serial location; rename methods and variables.

* Revert "Backport atomic from pynest-ng to avoid data race" because it introduces a new data race.

This reverts commit c4ed2c4.

* Fix typo

* Remove unused function

* Switch to auto or size_t instead of decltype.

* add whatsnew

* typo

* update text

* Update doc/htmldoc/whats_new/v3.9/index.rst

Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>

* Update doc/htmldoc/whats_new/v3.9/index.rst

Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>

* Started simplifying stopwatch

* Simplified stopwatch implementation and fixed bugs

* Fix problems and tidy up code

* Update nestkernel/stopwatch_impl.h

Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>

* Fix nest-server

* Update benchmark plots for documentation

* Update description

* Add website with correct benchmark results of NEST 3.8

* Fix naming

* Apply suggestions from code review

* Update doc/htmldoc/benchmark_results.rst

* Update doc/htmldoc/previous_benchmark_results.rst

Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>

* Add error description

* Update doc/htmldoc/previous_benchmark_results.rst

* Improve test for GetNodes()

* Made test_GetNodes MPI-safe

* Fix various bugs in GetNodes

* Fixes for backport from ng to master

* Make tests safe if NEST was built without threads

* Fix backport

* Check local_only also for no-match case.

Co-authored-by: med-ayssar <med.ayssar@gmail.com>

* Bump actions/stale from 9.1.0 to 10.1.0

Bumps [actions/stale](https://github.com/actions/stale) from 9.1.0 to 10.1.0.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@5bef64f...5f858e3)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-version: 10.1.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* bump version

* Bump actions/dependency-review-action from 4.7.2 to 4.8.1

Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 4.7.2 to 4.8.1.
- [Release notes](https://github.com/actions/dependency-review-action/releases)
- [Commits](actions/dependency-review-action@bc41886...40c09b7)

---
updated-dependencies:
- dependency-name: actions/dependency-review-action
  dependency-version: 4.8.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump github/codeql-action from 3.29.11 to 4.30.9

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.29.11 to 4.30.9.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@3c3833e...16140ae)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.30.9
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump actions/setup-python from 5.6.0 to 6.0.0

Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5.6.0 to 6.0.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@a26af69...e797f83)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-version: 6.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump peter-evans/repository-dispatch from 3.0.0 to 4.0.0

Bumps [peter-evans/repository-dispatch](https://github.com/peter-evans/repository-dispatch) from 3.0.0 to 4.0.0.
- [Release notes](https://github.com/peter-evans/repository-dispatch/releases)
- [Commits](peter-evans/repository-dispatch@ff45666...5fc4efd)

---
updated-dependencies:
- dependency-name: peter-evans/repository-dispatch
  dependency-version: 4.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump ossf/scorecard-action from 2.4.2 to 2.4.3

Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.4.2 to 2.4.3.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](ossf/scorecard-action@05b42c6...4eaacf0)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-version: 2.4.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump actions/cache from 4.2.4 to 4.3.0

Bumps [actions/cache](https://github.com/actions/cache) from 4.2.4 to 4.3.0.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@0400d5f...0057852)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-version: 4.3.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump psf/black from 25.1.0 to 25.9.0

Bumps [psf/black](https://github.com/psf/black) from 25.1.0 to 25.9.0.
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](psf/black@8a737e7...af0ba72)

---
updated-dependencies:
- dependency-name: psf/black
  dependency-version: 25.9.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump actions/upload-artifact from 4.6.2 to 5.0.0

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.6.2 to 5.0.0.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@ea165f8...330a01c)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: 5.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump github/codeql-action from 4.30.9 to 4.31.1

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.30.9 to 4.31.1.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@16140ae...5fe9434)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.31.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* add note in docs about how to use volume transmitter during network setup

* Add suggestion for future code improvement.

* Fix whitespace.

* Add empty line to comply with coding standards.

* Update models/stdp_dopamine_synapse.h

Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>

* Set expected SLI test file counts to 1 to facilitate SLI2Py sprint

* Broke one test function with multiple tests into multiple functions

* Add additional pytest marker to pyproject

* Connect array test for all_to_all

* Update testsuite/pytests/sli2py_regressions/test_ticket_710.py

* Update testsuite/pytests/sli2py_regressions/test_ticket_507.py

* Update testsuite/pytests/sli2py_regressions/test_ticket_433.py

* Update testsuite/pytests/sli2py_regressions/test_ticket_716.py

* Update testsuite/pytests/sli2py_regressions/test_ticket_737.py

Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>

* readd

* Make MPI test wrapper more robust when parametrizing with strings and functions

* Move test_connect_array_* tests from SLI to Py

* Adjust test to improved wrapper

* Fix Flake8 issues

* Convert non-thread-skipping from unittest to pytest

* Simplify tests to focus on connectivity generation.

* Remove test_get_nodes.sli, Python implementation already in place

* Port test_ginzburg_neuron from SLI to Py

* Fix line length

* Convert non-thread-skipping from unittest to pytest

* Add wrapper variant checking for identical results on all ranks

* Port test_global_rng from SLI to Py

* rm test 881

* Port mpitets/test_iaf_ring from SLI to Py and refactor in the process

* Turn off debug output

* port test using cursor

* Fix bug in GetLocalNodeCollection

* Port mpitests/test_localonly from SLI to Py

* Port mpitests/test_mip_generator to Python

* Delete sli version

* Make MPI test wrapper more robust when parametrizing with strings and functions

* Generalizd test to parameterized version covering almost all generator tests

* Fix copyright header

* Adjust test to improved wrapper

* Remove test_global_rng.sli to completed nest#3630

* Port test_multiple_synapses from SLI to Py

* Integrate one_to_one and pairwise_bernoulli cases into test_all_to_all and rename

* Include test_pp_psc_delta in test_generators and thus port from SLI to Py

* Add support for multimeter data and enforce tab-separated other.csv files

* Port test_rate_neurons_mpi from SLI to Py

* Ensure tests write tab-separated other.csv files

* Add support for multimeter data and enforce tab-separated other.csv files

* Ensure tests write tab-separated other.csv files

* Add support for test-specific assert functions

* Port tests for identical and individual spike trains from poisson generator from SLI to Py

* Fixed flake8 problems

* Remove test that has no meaningful function any more

* Port test ticket-955 from SLI to Py

* Turn off debug mode.

Co-authored-by: Jan Vogelsang <47158055+JanVogelsang@users.noreply.github.com>

* Remove test for default delay; handled by other tests today

* Simplified and integrated test

* Fix get_comparable_timesamples

* Add historic output comment

* Fixed typo in test

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Guido Trensch <19706694+gtrensch@users.noreply.github.com>
Co-authored-by: Dennis Terhorst <d.terhorst@fz-juelich.de>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Dennis Terhorst <terhorstd@users.noreply.github.com>
Co-authored-by: janskaar <jewskaar@gmail.com>
Co-authored-by: Jessica Mitchell <j.mitchell@fz-juelich.de>
Co-authored-by: jessica-mitchell <mitchell20j@gmail.com>
Co-authored-by: med-ayssar <med.ayssar@gmail.com>
Co-authored-by: Pooja Babu <75320801+pnbabu@users.noreply.github.com>
Co-authored-by: Jan Vogelsang <j.vogelsang@fz-juelich.de>
Co-authored-by: Jan Vogelsang <47158055+JanVogelsang@users.noreply.github.com>
Co-authored-by: Sebastian Spreizer <spreizer@web.de>
Co-authored-by: Melissa Lober <melissa.lober@gmx.de>
Co-authored-by: Melissa Lober <47082241+mlober@users.noreply.github.com>
Co-authored-by: C.A.P. Linssen <charl@turingbirds.com>
Co-authored-by: clinssen <c.linssen@fz-juelich.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@otcathatsya otcathatsya otcathatsya approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

PyNEST-NG
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@heplesser @otcathatsya