Skip to content

Create() does not work MPI-parallel with arrays of parameter values #3591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Create() does not work MPI-parallel with arrays of parameter values #3591

wants to merge 5 commits into from

Conversation

@med-ayssar
Copy link
Contributor

@med-ayssar med-ayssar commented Sep 29, 2025 •
edited
Loading

Fixes #3587

@med-ayssar med-ayssar mentioned this pull request Sep 29, 2025
Closed
3 tasks
heplesser
heplesser requested changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@med-ayssar Thanks for the PR, but I see some issues, see below. I wonder if we shouldn't leave the fix for PyNEST-NG—no user has complained about this ever ;).

pynest/nest/lib/hl_api_info.py
Comment on lines +277 to +279
only_local_nodes = list(itertools.compress(nodes, local_nodes))
if len(only_local_nodes) == 0:
return
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid of corner cases here. If SetStatus should trigger MPI communication, but some rank never calls SetStatus in the kernel, we will hang. So I would not want to return here.

pynest/nest/lib/hl_api_info.py
Comment on lines +281 to +282
if params_is_dict:
node_params = only_local_nodes[0].get() if set_status_nodes else nodes[0].get()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, I think the and set_status_nodes needs to stay where it is. The function here mixes in a not very good way setting node and synapse status and everything under this if, I believe, applies only to nodes.

@jessica-mitchell jessica-mitchell added T: Bug Wrong statements in the code or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Oct 6, 2025
@github-project-automation github-project-automation bot moved this to In progress in Kernel Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heplesser heplesser heplesser requested changes

@Gorka-PerCopp Gorka-PerCopp Awaiting requested review from Gorka-PerCopp

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Bug Wrong statements in the code or documentation

Projects

Kernel
Status: In progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create() does not work MPI-parallel with arrays of parameter values

3 participants

@med-ayssar @heplesser @jessica-mitchell