Fix a number of problems with GetNodes #3586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
added
T: Bug
med-ayssar
reviewed
Sep 28, 2025
Co-authored-by: med-ayssar <med.ayssar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a backport of a corresponding fix in PyNEST-NG. It fixes code leading to undefined MPI behaviour (passing
nullptrforsendbuftoMPI_Allgatherv()and corrects the selection logic if only neurons with certain parameters are requested, as well as fixing a doubling of device entries from threads. It furthermore extends the tests to cover more cases, especially parallel and including devices.The code for
GetNodes()could be further improved. I have done this in the PyNEST-NG branch, see https://github.com/heplesser/nest-simulator/blob/da99c325a540b1a769c59530b5e1436bae65f1ea/nestkernel/node_manager.cpp#L338, but will not backport this here any more.