-
Notifications
You must be signed in to change notification settings - Fork 381
Update built-in timer documentation #3490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this, it already looks really good. I had a look at the code again and have a few small improvements:
- diagram: change "Repeat once if buffer too small" to "Repeat once if not all spikes transmitted".
- diagram: block "if buffer can shrink" must be outside of "Repeat once if not all spikes transmitted".
- diagram: include another block after time_communicate_spike_data-block that is the opposite of "if buffer can shrink": "if buffer too small -> grow MPI buffer size".
- OMP parallel and OMP master with same capitalization
- question to @JanVogelsang : shouldn't the OMP parallel end before OMP master?
How about making the timer block backgrounds nest-orange instead of white?
No that's correct, OMP master sections only make sense within parallel sections, outside of them master is the only thread running anyway |
I'm not sure if "Repeat once if not all spikes transmitted" is actually better than "Repeat once if buffer too small". That makes it sound as if in the first round, the communicated spikes are already used and only the remaining spikes are communicated in the second round. |
This PR adds a diagram describing a simplified simulation run focusing on timers.
The diagram is generated via a script that converts YAML into a dot diagram. Thanks to @JoseJVS for providing the original version.
In addition, some links are added to try to connect various parts of the documentation together with respect to perforance, benchmarking, and timers.
https://nest-simulator--3490.org.readthedocs.build/en/3490/nest_behavior/built-in_timers.html#built-in-timers