Skip to content

Port unittest/test_voltmeter_reset to Pytests #3458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 15, 2025
Merged

Port unittest/test_voltmeter_reset to Pytests #3458

merged 3 commits into from
Apr 15, 2025

Conversation

jessica-mitchell
Copy link
Contributor

This conversion uses Mistral AI

@jessica-mitchell jessica-mitchell added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Apr 2, 2025
@github-project-automation github-project-automation bot moved this to In progress in PyNEST-NG Apr 2, 2025
@jessica-mitchell jessica-mitchell mentioned this pull request Apr 2, 2025
Open
heplesser
heplesser requested changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, the AI overlooked on subtest in all three cases, see suggestions.

@jessica-mitchell @heplesser
Apply suggestions from code review
0071208 
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
@heplesser heplesser merged commit 7445cd3 into nest:master Apr 15, 2025
24 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in PyNEST-NG Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heplesser heplesser heplesser approved these changes

Assignees
No one assigned
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.
Projects
PyNEST-NG
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessica-mitchell @heplesser