Fix issue with first spike passing through adaptive synapse #3384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clinssen
force-pushed
the
first_syn_spike
branch
from
edc9f65 to
b907e0d
Compare
terhorstd
added
S: High
|
@tomtetzlaff Ping! |
heplesser
requested changes
Mar 3, 2025
There was a problem hiding this comment.
@clinssen Thanks for this PR. It looks mostly good to me, but see my small suggestions inline. Could you add a little more text to the PR description to explain why/how things go wrong with the current implementation? Just for future reference.
tomtetzlaff
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Thanks @clinssen. This solved the issue with the order of update steps. After a period of silence, the synapse now fully recovers, as it should.
heplesser
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for first spike passing through an adaptive synapse in #1672 was erroneous and affects more than just the first spike. This PR fixes the fix.