Skip to content

Conversation

jessica-mitchell
Copy link
Contributor

@jessica-mitchell jessica-mitchell commented Aug 6, 2024

This PR adds an example for the ignore_and_fire model
Thanks to @tomtetzlaff for developing the content!

The documentation to generate the sketch from odg file is removed, as I don't think it's suitable for the purposes of the docs here.
See Read the Docs output here: https://nest-simulator--3276.org.readthedocs.build/en/3276/auto_examples/ignore_and_fire/index.html

jessica-mitchell and others added 30 commits January 16, 2024 09:09
@jessica-mitchell jessica-mitchell added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Aug 6, 2024
Copy link

Pull request automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Oct 21, 2024
@github-actions github-actions bot removed the stale Automatic marker for inactivity, please have another look here label Dec 20, 2024
Copy link

Pull request automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Feb 28, 2025
@heplesser
Copy link
Contributor

@mlober @tomtetzlaff Ping!

for various network sizes between :math:`N=1250` and :math:`N=13750`.
The number of incoming connections per neuron, the in-degree, is kept constant at :math:`K=1250`.
The total number of connections hence scales linearly with :math:`N`. For each simulation, we monitor the simulation
(wall clock) time, the time and population averaged firing rate, and the mean standard deviation of the excitatory

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "mean and standard deviation"

Dependence of the simulation time (top), the time and population averaged firing rate (middle) and the excitatory
synaptic weights (bottom) on the network size :math:`N` for the\ ``integrate-and-fire`` (black) and the
``ignore-and-fire`` variant of the network model (gray). The in-degree :math:`K=1250` is fixed. Figure generated using
:doc:`scaling.py </auto_examples/ignore_and_fire/scaling>`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link is not working.


* reset and refractoriness:

.. math:: \forall{}k,\ \forall t \in \left(t_{k}^{i},\,t_{k}^{i}+\tau_\text{ref}\right]:\quad V_{i}(t)=V_\text{reset}
Copy link

@tomtetzlaff tomtetzlaff Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refractoriness interval needs be closed on both sides:
.. math:: \forall{}k,\ \forall t \in \left[t_{k}^{i},,t_{k}^{i}+\tau_\text{ref}\right]:\quad V_{i}(t)=V_\text{reset}

.. math::

\begin{aligned}
&\forall{}k,\ \forall t \notin \left[t_{i}^{k},\,t_{i}^{k}+\tau_\text{ref}\right):\\

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above:
&\forall{}k,\ \forall t \notin \left[t_{i}^{k},,t_{i}^{k}+\tau_\text{ref}\right]:\

| :math:`C_\text{m}` | | membrane capacitance |
| | :math:`250\,\text{pF}` | |
+---------------------------------+--------------------------------+----------------------+
| :math:`\color{blue} R_\text{m}` | :math:`\tau \ | membrane resistance |
Copy link

@tomtetzlaff tomtetzlaff Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace

\tau \ _\text{m}

by

\tau_\text{m}

Network sketch (see `Fig. 8 <https://doi.org/10.1371/journal.pcbi.1010086.g008>`_
in Senk et al. [3]_).

Detailed desciption of network model

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: "description"

@@ -0,0 +1,608 @@
.. _sec_model_description:

Two population STDP network model

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this name weird. In the ACA testcases, we define "TwoPopulationNetworkPlastic" as this model's "uid", to have something more telling than "hpc_benchmark". I'd suggest to either stick to this (without spaces), or to use something less abstract, such as "Balanced random network with STDP synapses".

Copy link

@tomtetzlaff tomtetzlaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jessica-mitchell . I found few minor issues in the documentation and left some comments.

@github-project-automation github-project-automation bot moved this from In progress to Review in Documentation Mar 10, 2025
@github-actions github-actions bot removed the stale Automatic marker for inactivity, please have another look here label Mar 10, 2025
Copy link

github-actions bot commented May 9, 2025

Pull request automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Enhancement New functionality, model or documentation
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

3 participants