Skip to content

Conversation

@jhnnsnk
Copy link
Contributor

@jhnnsnk jhnnsnk commented Apr 4, 2024

This PR replaces #2992, for the discussion refer to the original PR.

clemensk0 and others added 30 commits July 20, 2023 13:36


update the connectivity concepts documentation
Revise connection_management.rst
Revise based on PR conversation and recent changes
Add class and directive to center text in rst
@jhnnsnk jhnnsnk requested a review from heplesser April 4, 2024 13:18
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhnnsnk Thanks! I just have minor suggestions.
@jessica-mitchell Can you review this PR as soon as possible for inclusion on 3.7?
@terhorstd Adding this to the 3.7 milestone, it is only documentation but important documentation.

@heplesser heplesser added this to the NEST 3.7 milestone Apr 4, 2024
@heplesser heplesser added T: Enhancement New functionality, model or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Apr 4, 2024
jhnnsnk and others added 8 commits April 4, 2024 16:04
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
@jhnnsnk jhnnsnk requested a review from heplesser April 4, 2024 14:24
@jessica-mitchell
Copy link
Contributor

@jessica-mitchell Can you review this PR as soon as possible for inclusion on 3.7?

yep will look at it tonight

@jessica-mitchell jessica-mitchell self-requested a review April 4, 2024 18:26
@jessica-mitchell jessica-mitchell merged commit 799ab2d into nest:master Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Enhancement New functionality, model or documentation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants