Skip to content

Conversation

@otcathatsya
Copy link
Contributor

@otcathatsya otcathatsya commented Mar 25, 2024

Same description is given a few lines above

Copy link
Contributor

@jessica-mitchell jessica-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!- @otcathatsya I see there are some 'check annotations' from GitHub actions below the file changed, which I've never seen before - do you know why thats there?

@otcathatsya
Copy link
Contributor Author

LGTM thanks!- @otcathatsya I see there are some 'check annotations' from GitHub actions below the file changed, which I've never seen before - do you know why thats there?

I have not seen it before either, but looks like it's some kind of GitHub Experimental feature that shows potential pipeline issues? Though it looks like most of them are unrelated to the files the pull request actually touches, so I think we should be able to ignore it(?)

@jessica-mitchell jessica-mitchell merged commit 00bfb49 into nest:master Mar 26, 2024
@jessica-mitchell jessica-mitchell added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants