-
Notifications
You must be signed in to change notification settings - Fork 391
Correctly handle random parameters appearing in the denominator #3158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
You mention in the message that you developed the PR in collaboration with Jannik Grundler.
Maybe do a co-authored commit (if he has a GitHub account) to give him also some credit in the commit history.
Good point @ackurth, you can already find it here: https://github.com/nest/nest-simulator/pull/3158/commits |
Ah, I did not see this. |
Co-authored-by: Jannik Grundler <jannik.grundler@rwth-aachen.de>
Fixed. |
mlober
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Now this looks good to me.
This PR fixes #3156 and ensures that expressions containing random parameters in the denominator are evaluated correctly. It also fixes a minor error in the SLI interface.
Developed in collaboration with Jannik Grundler.