Skip to content

Conversation

@heplesser
Copy link
Contributor

@heplesser heplesser commented Mar 18, 2024

This PR fixes #3156 and ensures that expressions containing random parameters in the denominator are evaluated correctly. It also fixes a minor error in the SLI interface.

Developed in collaboration with Jannik Grundler.

@heplesser heplesser added T: Bug Wrong statements in the code or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Mar 18, 2024
@heplesser heplesser added this to the NEST 3.7 milestone Mar 18, 2024
@heplesser heplesser requested review from ackurth and mlober March 18, 2024 12:29
Copy link
Contributor

@ackurth ackurth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
You mention in the message that you developed the PR in collaboration with Jannik Grundler.
Maybe do a co-authored commit (if he has a GitHub account) to give him also some credit in the commit history.

@heplesser
Copy link
Contributor Author

Looks good to me. You mention in the message that you developed the PR in collaboration with Jannik Grundler. Maybe do a co-authored commit (if he has a GitHub account) to give him also some credit in the commit history.

Good point @ackurth, you can already find it here: https://github.com/nest/nest-simulator/pull/3158/commits

@ackurth
Copy link
Contributor

ackurth commented Mar 19, 2024

Looks good to me. You mention in the message that you developed the PR in collaboration with Jannik Grundler. Maybe do a co-authored commit (if he has a GitHub account) to give him also some credit in the commit history.

Good point @ackurth, you can already find it here: https://github.com/nest/nest-simulator/pull/3158/commits

Ah, I did not see this.
But there is no GitHub account linked to this mail address.
Jannik's account name is Jannik-Grundler, the mail address is jannik.grundler@rwth-aachen.de.

@heplesser
Copy link
Contributor Author

Looks good to me. You mention in the message that you developed the PR in collaboration with Jannik Grundler. Maybe do a co-authored commit (if he has a GitHub account) to give him also some credit in the commit history.

Good point @ackurth, you can already find it here: https://github.com/nest/nest-simulator/pull/3158/commits

Ah, I did not see this. But there is no GitHub account linked to this mail address. Jannik's account name is Jannik-Grundler, the mail address is jannik.grundler@rwth-aachen.de.

Fixed.

Copy link
Contributor

@mlober mlober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Now this looks good to me.

@heplesser heplesser merged commit 90ad974 into nest:master Mar 19, 2024
@heplesser heplesser deleted the fix-3156 branch April 24, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

When dividing by random parameter, one obtains fixed, not random values

3 participants