Skip to content

Make -Dwith-mpi respect provided path and ensure "default off" options are turned on only by explicit ON #3148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
terhorstd merged 5 commits into from
Mar 25, 2024
Merged

Make -Dwith-mpi respect provided path and ensure "default off" options are turned on only by explicit ON #3148

terhorstd merged 5 commits into from
Mar 25, 2024

Conversation

@gtrensch
Copy link
Contributor

@gtrensch gtrensch commented Mar 12, 2024 •
edited by heplesser
Loading

Unify the handling of CMake options and explicitly check the contents of variables.

To be more precise:

  • Some options with default OFF could previously be turned on by any non-empty string. Now ON is explicitly required.
  • Previously, passing -Dwith-mpi=/opt/local would not make CMake look for MPI in /opt/local, it would search in default locations. Now it respects the path given.

This is a replacement for #3112.

@gtrensch gtrensch requested a review from heplesser March 12, 2024 12:38
heplesser
heplesser requested changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gtrensch This needs a little fix to work, my fault, see suggestion below.

@heplesser heplesser changed the title Unify the handling of CMake options Make -Dwith-mpi respect provided path and ensure "default off" options are turned on only by explicit ON Mar 12, 2024
@heplesser heplesser requested a review from terhorstd March 12, 2024 12:50
@heplesser heplesser added T: Bug Wrong statements in the code or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Mar 12, 2024
heplesser
heplesser approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed CMake syntax, thus approving.

This was referenced Mar 12, 2024
Closed
Closed
terhorstd
terhorstd approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@terhorstd terhorstd merged commit 3ddf5eb into nest:master Mar 25, 2024
@BrewTestBot BrewTestBot mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heplesser heplesser heplesser approved these changes

@terhorstd terhorstd terhorstd approved these changes

Assignees

No one assigned

Labels

I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation

Projects

Installation
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gtrensch @heplesser @terhorstd