Add CMAKE option for optimizing performance of benchmarks #3140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessica-mitchell
added
S: Normal
heplesser
requested changes
Mar 7, 2024
Contributor
heplesser
left a comment
heplesser
left a comment
There was a problem hiding this comment.
@jessica-mitchell Thanks a lot! I revised and extended the text a bit.
jessica-mitchell
commented
Mar 7, 2024
jessica-mitchell
commented
Mar 7, 2024
Co-authored-by: Hans Ekkehard Plesser <hans.ekkehard.plesser@nmbu.no>
jessica-mitchell
commented
Mar 7, 2024
jessica-mitchell
commented
Mar 7, 2024
jessica-mitchell
commented
Mar 7, 2024
jessica-mitchell
commented
Mar 7, 2024
jessica-mitchell
commented
Mar 7, 2024
jessica-mitchell
commented
Mar 7, 2024
jessica-mitchell
commented
Mar 7, 2024
jessica-mitchell
commented
Mar 7, 2024
jessica-mitchell
commented
Mar 7, 2024
heplesser
approved these changes
Mar 7, 2024
Contributor
Author
|
@heplesser can we merge this with one reviewer, or do you want others to comment? |
Contributor
Let's wait a little :). |
ackurth
approved these changes
Mar 25, 2024
Contributor
ackurth
left a comment
ackurth
left a comment
There was a problem hiding this comment.
This is a very clear and understandable descriptions.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the cmake option discussed with the developers about performance optimization.
A link is also added from the benchmarking page.
@heplesser @ackurth @otcathatsya Please take a look if this is reasonable. I was not sure where in the list of cmake options it would best fit, and if the language used is fully appropriate.