Skip to content

Automatically adjust column widths in testsuite report #3129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
terhorstd merged 1 commit into from
Mar 12, 2024
Merged

Automatically adjust column widths in testsuite report #3129

terhorstd merged 1 commit into from
Mar 12, 2024

Conversation

@heplesser
Copy link
Contributor

@heplesser heplesser commented Mar 1, 2024

This PR makes sure that columns format nicely even if phase name become longer. Also switches to format strings.

@heplesser heplesser added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Mar 1, 2024
@heplesser heplesser requested a review from lekshmideepu March 1, 2024 14:29
@heplesser heplesser requested review from steffengraber and terhorstd and removed request for lekshmideepu March 12, 2024 08:53
steffengraber
steffengraber approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@steffengraber steffengraber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

terhorstd
terhorstd approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terhorstd terhorstd merged commit 8dd4b52 into nest:master Mar 12, 2024
@BrewTestBot BrewTestBot mentioned this pull request Apr 12, 2024
Merged
@heplesser heplesser deleted the fix-test-report-format branch April 24, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terhorstd terhorstd terhorstd approved these changes

+1 more reviewer

@steffengraber steffengraber steffengraber approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.

Projects

Build system and CI
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@heplesser @steffengraber @terhorstd