Add detailed timers for gathering and delivering secondary events #3097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
added
T: Enhancement
Contributor
|
Thank you for the pull request. I have tested the code with network models with secondary events. The result shows that the new timers can indeed account for a previously unknown part of simulation time in such models. It looks good to me too! |
Contributor
Author
Excellent. Could you then formally approve the PR so I can merge it? |
HanjiaJiang
approved these changes
Feb 14, 2024
Contributor
HanjiaJiang
left a comment
HanjiaJiang
left a comment
There was a problem hiding this comment.
The code looks very nice to me. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds detailed timers that measure time used to gather and deliver secondary events in the same way as gathering and delivering spike is measured.