Properly handle OpenMP linker flags #3051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
added
T: Bug
gtrensch
requested changes
Dec 18, 2023
Contributor
gtrensch
left a comment
gtrensch
left a comment
There was a problem hiding this comment.
Thank you for this contribution. It looks good to me. I would just like to make one suggestion for improvement. In order to report on the OpenMP libraries used, we could add the following to ConfigureSummary.cmake, after line 102:
message( " Libraries : ${OpenMP_CXX_LIBRARIES}" )
Contributor
Author
@gtrensch Thanks for the suggestion, fixed! |
Contributor
Author
pnbabu
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, we placed
OpenMP_CXX_FLAGSin theMODULE_LINK_LIBSfor nest. This is not quite correct and meant thatlibompwas missing from the list of libraries returned bynest-config --libs, which in turn caused trouble for building external models with OpenMP, at least on macOS. This PR fixes this.