Skip to content

Increase admonition to warning #3050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Helveg merged 1 commit into from
Dec 22, 2023
Merged

Increase admonition to warning #3050

Helveg merged 1 commit into from
Dec 22, 2023

Conversation

@Helveg
Copy link
Contributor

@Helveg Helveg commented Dec 15, 2023 •
edited by terhorstd
Loading

This admonition feels like it should be a more clearly visible warning

[edit] review docs here

@terhorstd terhorstd added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Dec 15, 2023
@terhorstd
Copy link
Contributor

terhorstd commented Dec 15, 2023

Job failure is not related to changes. restarted.

terhorstd
terhorstd approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Helveg Helveg merged commit 91a02ed into master Dec 22, 2023
@Helveg Helveg deleted the Helveg-patch-1 branch December 22, 2023 10:47
@BrewTestBot BrewTestBot mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terhorstd terhorstd terhorstd approved these changes

@jessica-mitchell jessica-mitchell Awaiting requested review from jessica-mitchell

Assignees

No one assigned

Labels

I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.

Projects

Documentation
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Helveg @terhorstd