Skip to content

Conversation

@mlober
Copy link
Contributor

@mlober mlober commented Dec 7, 2023

This PR fixes issue #2991 .

@mlober mlober requested review from heplesser and terhorstd December 7, 2023 09:59
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes necessary to stay consistent with other loops and not copy elements of the vector.

@heplesser heplesser linked an issue Dec 11, 2023 that may be closed by this pull request
mlober and others added 2 commits December 11, 2023 11:23
Co-authored-by: Dennis Terhorst <terhorstd@users.noreply.github.com>
Co-authored-by: Dennis Terhorst <terhorstd@users.noreply.github.com>
@heplesser heplesser added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Dec 11, 2023
Copy link
Contributor

@terhorstd terhorstd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@heplesser heplesser merged commit ee575c7 into nest:master Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Superfluous clearing of containers

3 participants