Replace assertDictContainsSubset() which has been removed in Python 3.12 #2997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heplesser
added
T: Bug
otcathatsya
approved these changes
Nov 20, 2023
janskaar
suggested changes
Nov 21, 2023
Contributor
Author
|
@janskaar I have now fixed the PR, putting the dictionaries in proper order and making it a function with its own test. Since #2834 hiked Python requirements to 3.10, using the dict merge operator is no problem. I removed one test for getverbosity—no need to explicitly check it returns and int value. The remaining test will fail if it doesn't. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://stackoverflow.com/questions/20050913/python-unittests-assertdictcontainssubset-recommended-alternative for the solution I used.
High priority because it breaks testsuite in Python 3.12.