Skip to content

Port sinusoidal generator tests (SLI-2-Py) #2976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
heplesser merged 6 commits into from
Oct 26, 2023
Merged

Port sinusoidal generator tests (SLI-2-Py) #2976

heplesser merged 6 commits into from
Oct 26, 2023

Conversation

@nicolossus
Copy link
Member

@nicolossus nicolossus commented Oct 17, 2023

This is a replacement for #2768. With this PR, the ported tests for sinusoidal_poisson_generator and sinusoidal_gamma_generator share a common test suite through the Pytest parametrization functionality.

@nicolossus nicolossus mentioned this pull request Oct 17, 2023
Closed
@nicolossus nicolossus added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Oct 17, 2023
@heplesser heplesser merged commit 9aadfe9 into nest:master Oct 26, 2023
@nicolossus nicolossus deleted the port_test_sinusoidal_gamma_generator branch October 29, 2023 10:11
@BrewTestBot BrewTestBot mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heplesser heplesser heplesser approved these changes

Assignees

No one assigned

Labels

I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicolossus @heplesser @med-ayssar