Skip to content

Conversation

@nicolossus
Copy link
Member

@nicolossus nicolossus commented Oct 9, 2023

Currently the Pylint checker fails due to a new, stricter version. This PR fix the errors Pylint points out.

@nicolossus nicolossus added T: Bug Wrong statements in the code or documentation S: High Should be handled next I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Oct 9, 2023
@nicolossus nicolossus requested a review from heplesser October 9, 2023 09:55
Copy link
Contributor

@heplesser heplesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nicolossus! We cannot unconditionally import matplotlib. Tests should run on systems without it. Therefore, I created #2972 as a replacement. Can you close this one?

@nicolossus nicolossus closed this Oct 10, 2023
@nicolossus nicolossus deleted the fix_pylint_errors branch October 10, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: High Should be handled next T: Bug Wrong statements in the code or documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants