Skip to content

Sli2py iaf_psc_alpha_multisynapse #2929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
heplesser merged 6 commits into from
Oct 20, 2023
Merged

Sli2py iaf_psc_alpha_multisynapse #2929

heplesser merged 6 commits into from
Oct 20, 2023

Conversation

@janskaar
Copy link
Contributor

@janskaar janskaar commented Sep 11, 2023

No description provided.

@terhorstd terhorstd added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Sep 19, 2023
@terhorstd terhorstd changed the title Sli2py iaf psc alpha multisynapse Sli2py iaf_psc_alpha_multisynapse Sep 19, 2023
@nicolossus nicolossus mentioned this pull request Oct 17, 2023
Merged
@nicolossus nicolossus self-requested a review October 17, 2023 14:37
nicolossus
nicolossus suggested changes Oct 17, 2023
View reviewed changes
Copy link
Member

@nicolossus nicolossus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janskaar Thanks, overall this looks good! I have some minor suggestions for which I have created a PR towards your branch, see janskaar#1.

@janskaar janskaar requested a review from nicolossus October 19, 2023 11:38
nicolossus
nicolossus approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@nicolossus nicolossus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@heplesser heplesser merged commit 3188c0a into nest:master Oct 20, 2023
@janskaar janskaar deleted the sli2py_iaf_psc_alpha_multisynapse branch February 6, 2024 13:22
@BrewTestBot BrewTestBot mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nicolossus nicolossus nicolossus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@janskaar @nicolossus @heplesser @terhorstd