Skip to content

Allow NodeCollection slicing with list of NumPy integers #2882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Helveg merged 2 commits into from
Aug 10, 2023
Merged

Allow NodeCollection slicing with list of NumPy integers #2882

Helveg merged 2 commits into from
Aug 10, 2023

Conversation

@nicolossus
Copy link
Member

@nicolossus nicolossus commented Aug 9, 2023

Resolves #2637.

@nicolossus nicolossus added T: Enhancement New functionality, model or documentation S: Normal Handle this with default priority I: External API Developers of extensions or other language bindings may need to adapt their code labels Aug 9, 2023
@nicolossus nicolossus requested review from Helveg and heplesser August 9, 2023 12:22
@Helveg Helveg merged commit cd1cdcb into nest:master Aug 10, 2023
@nicolossus nicolossus deleted the fix_issue_2637 branch August 10, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heplesser heplesser heplesser approved these changes

+1 more reviewer

@Helveg Helveg Helveg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

I: External API Developers of extensions or other language bindings may need to adapt their code S: Normal Handle this with default priority T: Enhancement New functionality, model or documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Indexing a NodeCollection with a list of np.int32 raises error, while numpy.ndarray of np.int32 does not.

3 participants

@nicolossus @heplesser @Helveg