Transpile test-setconnections_threads.sli #2760
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolossus
suggested changes
May 15, 2023
| @pytest.fixture(autouse=True) | ||
| def prepare(have_threads): | ||
| nest.ResetKernel() | ||
| threads = 2 if have_threads else 1 |
Member
There was a problem hiding this comment.
I see that this way of setting the threads also was done in the SLI version. However, based on the name of test, I would expect this to be a multithreaded test. I suggest to make this a multithreaded test only with pytest.mark.skipif_missing_threads.
Contributor
|
@med-ayssar Remember to merge master to activate black-testing. |
nicolossus
added
S: Normal
nicolossus
suggested changes
Oct 17, 2023
Member
nicolossus
left a comment
nicolossus
left a comment
There was a problem hiding this comment.
@med-ayssar I have created a PR towards your branch with suggested changes and a merge with master. See med-ayssar#4. Once those changes are in, your PR can be merged with master.
Member
|
Replaced by #2978. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.