Skip to content

Double disposal #33

@dsyme

Description

@dsyme

While looking over the code I noticed this. There seems to be a double disposal here and here.

As far as I understand it, if the TryAdvance() returns false, then it is the responsibility of the owner of the iterator to then call Dispose() - the disposal shouldn't be called inside TryAdvance()

This is actually fixed in this work at this point by just deleting the disposal logic in the tryAdvance(), though it could be fixed directly instead.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions