fix: preserve sidebar scrolling while streaming - #1789
Closed
Michaelyklam wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Thanks @Michaelyklam — this shipped in v0.51.18 (commit GitHub didn't auto-close because the merge commit only references the squash-merged stage branch, not your fork's commit directly — closing manually for hygiene. Live now on existing installs after Release notes: https://github.com/nesquena/hermes-webui/releases/tag/v0.51.18 |
pull Bot
pushed a commit
to soitun/hermes-webui
that referenced
this pull request
May 7, 2026
…1789, nesquena#1790, nesquena#1791, nesquena#1794) Constituent PRs: - nesquena#1783 (@Sanjays2402) custom provider + :free/:beta/:thinking suffix fix. Closes nesquena#1776. - nesquena#1789 (@Michaelyklam) preserve sidebar scrolling while streaming. Closes nesquena#1784. - nesquena#1790 (@Michaelyklam) keep workspace open from preview breadcrumb. Closes nesquena#1785. - nesquena#1791 (@Michaelyklam) keep assistant-only stream deltas on current turn. Closes nesquena#1787. - nesquena#1794 (@nesquena-hermes, APPROVED by @nesquena) UX bundle: rail tooltip cascade fix, +new-conversation has-tooltip--bottom-right variant, context-menu hover-bg, rename pre-fill via setSelectionRange. Tests: 4723 → 4747 collected (+24). 4733 passed, 0 failed in 149s. Pre-release verification: - All 5 PRs CI-green individually - File overlaps (style.css + ui.js between nesquena#1789 + nesquena#1794) auto-merged cleanly - node -c clean on all 4 changed JS files - Browser API sanity 11/11 endpoints - Pre-stamp re-fetch: all PR heads match local rebases - Opus advisor: SHIP all 5, 0 MUST-FIX, 1 SHOULD-NOTE on test pattern divergence (acceptable) Closes nesquena#1776, nesquena#1784, nesquena#1785, nesquena#1787.
Du7chManiac
pushed a commit
to TheCouchCoder-com/hermes-webui
that referenced
this pull request
May 13, 2026
v0.51.18 — 5-PR batch (nesquena#1783, nesquena#1789, nesquena#1790, nesquena#1791, nesquena#1794) # Conflicts: # CHANGELOG.md
SysAdminDoc
pushed a commit
to SysAdminDoc/hermes-webui
that referenced
this pull request
Jun 26, 2026
SysAdminDoc
pushed a commit
to SysAdminDoc/hermes-webui
that referenced
this pull request
Jun 26, 2026
…1789, nesquena#1790, nesquena#1791, nesquena#1794) Constituent PRs: - nesquena#1783 (@Sanjays2402) custom provider + :free/:beta/:thinking suffix fix. Closes nesquena#1776. - nesquena#1789 (@Michaelyklam) preserve sidebar scrolling while streaming. Closes nesquena#1784. - nesquena#1790 (@Michaelyklam) keep workspace open from preview breadcrumb. Closes nesquena#1785. - nesquena#1791 (@Michaelyklam) keep assistant-only stream deltas on current turn. Closes nesquena#1787. - nesquena#1794 (@nesquena-hermes, APPROVED by @nesquena) UX bundle: rail tooltip cascade fix, +new-conversation has-tooltip--bottom-right variant, context-menu hover-bg, rename pre-fill via setSelectionRange. Tests: 4723 → 4747 collected (+24). 4733 passed, 0 failed in 149s. Pre-release verification: - All 5 PRs CI-green individually - File overlaps (style.css + ui.js between nesquena#1789 + nesquena#1794) auto-merged cleanly - node -c clean on all 4 changed JS files - Browser API sanity 11/11 endpoints - Pre-stamp re-fetch: all PR heads match local rebases - Opus advisor: SHIP all 5, 0 MUST-FIX, 1 SHOULD-NOTE on test pattern divergence (acceptable) Closes nesquena#1776, nesquena#1784, nesquena#1785, nesquena#1787.
SysAdminDoc
pushed a commit
to SysAdminDoc/hermes-webui
that referenced
this pull request
Jun 26, 2026
v0.51.18 — 5-PR batch (nesquena#1783, nesquena#1789, nesquena#1790, nesquena#1791, nesquena#1794)
bernyforce
pushed a commit
to bernyforce/hermes-webui
that referenced
this pull request
Jul 29, 2026
bernyforce
pushed a commit
to bernyforce/hermes-webui
that referenced
this pull request
Jul 29, 2026
…1789, nesquena#1790, nesquena#1791, nesquena#1794) Constituent PRs: - nesquena#1783 (@Sanjays2402) custom provider + :free/:beta/:thinking suffix fix. Closes nesquena#1776. - nesquena#1789 (@Michaelyklam) preserve sidebar scrolling while streaming. Closes nesquena#1784. - nesquena#1790 (@Michaelyklam) keep workspace open from preview breadcrumb. Closes nesquena#1785. - nesquena#1791 (@Michaelyklam) keep assistant-only stream deltas on current turn. Closes nesquena#1787. - nesquena#1794 (@nesquena-hermes, APPROVED by @nesquena) UX bundle: rail tooltip cascade fix, +new-conversation has-tooltip--bottom-right variant, context-menu hover-bg, rename pre-fill via setSelectionRange. Tests: 4723 → 4747 collected (+24). 4733 passed, 0 failed in 149s. Pre-release verification: - All 5 PRs CI-green individually - File overlaps (style.css + ui.js between nesquena#1789 + nesquena#1794) auto-merged cleanly - node -c clean on all 4 changed JS files - Browser API sanity 11/11 endpoints - Pre-stamp re-fetch: all PR heads match local rebases - Opus advisor: SHIP all 5, 0 MUST-FIX, 1 SHOULD-NOTE on test pattern divergence (acceptable) Closes nesquena#1776, nesquena#1784, nesquena#1785, nesquena#1787.
bernyforce
pushed a commit
to bernyforce/hermes-webui
that referenced
this pull request
Jul 29, 2026
v0.51.18 — 5-PR batch (nesquena#1783, nesquena#1789, nesquena#1790, nesquena#1791, nesquena#1794)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
origin/masterworktree: a sidebar wheel gesture followed by the nextscrollIfPinned()call forced#messages.scrollTopfrom0to the chat bottom (3073in the fixture).#messagesand skips only that immediate programmatic chat-pane scroll write.What Changed
wheelandtouchmovethat record recent non-chat-pane scroll intent without callingpreventDefault().scrollIfPinned()to return early for a short 350ms window after a non-message scroll gesture, preventing token-render auto-scroll from fighting sidebar scrolling.overscroll-behavior-y: containandtouch-action: pan-yto.session-list.tests/test_streaming_sidebar_scroll.py.Why It Matters
Users often browse or switch sessions while a long response is still streaming. The chat pane can keep its normal pinned behavior when the user is watching it, but sidebar scroll gestures should remain independent and responsive.
Verification
origin/master(9875967): sidebar wheel + nextscrollIfPinned()moved#messages.scrollTopfrom0to3073.127.0.0.1:18784) with a synthetic 180-session sidebar and active streaming session:scrollIfPinned():#messages.scrollTopstayed0scrollIfPinned():#messages.scrollTopmoved to2992.session-listcomputed CSS:overscroll-behavior-y: contain; touch-action: pan-ypython -m pytest tests/test_streaming_sidebar_scroll.py -q→3 passedpython -m pytest tests/test_streaming_sidebar_scroll.py tests/test_streaming_markdown.py::TestExistingStreamingGuardsIntact -q→10 passedgit diff --check→ passedUI media / evidence:
Structured QA evidence: https://raw.githubusercontent.com/Michaelyklam/hermes-webui/fix/issue-1784-sidebar-scroll-streaming/docs/pr-media/1784/sidebar-scroll-qa.json
Fixes #1784
Risks / Follow-ups
scrollIfPinned(), not explicitscrollToBottom(), so a user click on the bottom button still restores the chat pane immediately.Model Used