Fix MSVC clz/ctz impl #2
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of
ctz32incorrectly used_BitScanForward,which can cause division by zero exception(Crash) in
js_atodwhen using likevar x = 3.0.Details:
in
js_atodctz32return wrong value making radix1 to be 0, which propagates tomul_powand causesl = (f + d - 1) / dwithd = 0.Then crash.