Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Duktape 2.3.0 #851

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Update to Duktape 2.3.0 #851

merged 1 commit into from
Jun 17, 2019

Conversation

RobLoach
Copy link
Contributor

@RobLoach RobLoach commented Jun 8, 2019

nesbox
nesbox reviewed Jun 17, 2019
View reviewed changes
Copy link
Owner

@nesbox nesbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, seems you forget to update the duktape.c file.
Thank you for the PR.

@nesbox
Copy link
Owner

nesbox commented Jun 17, 2019

Ahh, I see it in the 3rd-party repo, sorry :)

nesbox
nesbox approved these changes Jun 17, 2019
View reviewed changes
Copy link
Owner

@nesbox nesbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
thank you

@nesbox nesbox merged commit a8e37b7 into nesbox:master Jun 17, 2019
nesbox added a commit that referenced this pull request Jun 17, 2019
@nesbox
#851 sync with 3rdparty
f9ddc11
@nesbox nesbox added the enhancement Improvement of existing feature or adding something new label Jun 17, 2019
@nesbox nesbox added this to the 0.80.0 milestone Jun 17, 2019
@nesbox nesbox removed this from the 0.80.0 milestone Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nesbox nesbox nesbox approved these changes

Assignees

@RobLoach RobLoach

Labels
enhancement Improvement of existing feature or adding something new
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobLoach @nesbox