Fix (and simplify) blurry Sokol rendering #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for the PR, I'll review and approve it soon... |
nesbox
approved these changes
Mar 21, 2019
nesbox
added a commit
that referenced
this pull request
Mar 21, 2019
nesbox
added
the
enhancement
|
Oooh my carelessness… Thanks >_< On a sided note, you have made sure it works correctly on other platforms such as Windows and Linux, right? |
|
I tested it on MacOS and Windows, works correctly. |
This was referenced Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm by no means experienced with Sokol, but I somehow managed to get a fix.
The first commit already fixes the blurriness, while the second one e968db3 aims at getting rid of the unnecessary upscaling process taken from the examples, but I cannot conveniently test the output on platforms other than macOS/Metal. In particular, I'm not sure whether the image will flip vertically with different backends (with left-handed and right-handed cooordinate systems), so this should not be merged until anyone helps confirm the correctness on other devices — I'd appreciate it!
Apologies for flooding with PRs, and thanks for your effort and time (^ ^;)