Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix -fullscreen #813

Merged
merged 1 commit into from
Feb 24, 2019
Merged

fix -fullscreen #813

merged 1 commit into from
Feb 24, 2019

Conversation

cuu
Copy link
Contributor

@cuu cuu commented Feb 22, 2019

src/system/sdlgpu.c start

the studioInit is called before SDL_CreateWindow
so the goFullscreen wont get a valid window ID ,makes the fullscreen not working at all

so seperate the goFullscreen from studioInit and call it after SDL_CreateWindow
everything works now

Copy link
Owner

@nesbox nesbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good
thank you

@nesbox nesbox merged commit 613c2df into nesbox:master Feb 24, 2019
@nesbox nesbox added the bug label Feb 24, 2019
@nesbox nesbox added this to the 0.80.0 milestone Feb 24, 2019
@nesbox nesbox removed this from the 0.80.0 milestone Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants