fix tic_modulo #2676
Merged
fix tic_modulo #2676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
approved these changes
Sep 6, 2024
|
I just found there's an existing function tic_modulo. This would be better: |
|
I've changed this to a draft because tic_modulo may be broken; it produces out of range values if x is a negative multiple of m. I'm going to examine things and see if correcting this will break things or if things are currently broken. |
|
From what I see nothing depends on broken behavior from tic_modulo, and I did find a related bug and created an issue for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Large values for map offsets can cause slowdown due to being unwound with increment loops on each tile drawn. This change unwinds the coordinates with modulus instead.
Resolves #2678