Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixes #1913. animEffect() seems to expect a value between 0 and 1, and #1913 is caused by the surf coverFade animation lerping past 1, which feeds values greater than 256 into fadePalette(), causing the flashing colors. This PR clamps movie ticks for each item ensuring animEffect won't receive values > 1. This could create issues if any animation items rely on playing past their end. I didn't notice any while visually checking the editor and surf menu animations, but I could easily have missed something. It might be better to move this clamp directly to the start of animEffect(). Alternative fixes for #1913 include clamping the fadePalette() value between 0 and 256, or stopping the animation at the right time.
- Loading branch information