forked from driftluo/tentacle
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support proxy and onion #392
Open
eval-exec
wants to merge
15
commits into
nervosnetwork:master
Choose a base branch
from
eval-exec:exec/proxy-and-onion
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0b06264
to
36312c5
Compare
9 tasks
d41cd7a
to
0312d4b
Compare
6b1f15f
to
f620bfe
Compare
73e178c
to
a341d27
Compare
0bd891a
to
f338466
Compare
Signed-off-by: Eval EXEC <execvy@gmail.com>
Signed-off-by: Eval EXEC <execvy@gmail.com>
3f8d867
to
4000bf1
Compare
35f76e1
to
624171d
Compare
driftluo
reviewed
Mar 13, 2025
tentacle/src/transports/mod.rs
Outdated
@@ -162,7 +166,7 @@ mod os { | |||
|
|||
fn listen(self, address: Multiaddr) -> Result<Self::ListenFuture> { | |||
match find_type(&address) { | |||
TransportType::Tcp => { | |||
TransportType::Tcp | TransportType::Onion => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onion should return Err(TransportErrorKind::NotSupported(address))
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Fixed.
Signed-off-by: Eval EXEC <execvy@gmail.com>
Signed-off-by: Eval EXEC <execvy@gmail.com>
Signed-off-by: Eval EXEC <execvy@gmail.com>
Signed-off-by: Eval EXEC <execvy@gmail.com>
…ocket and return a Result<TcpSocket> Signed-off-by: Eval EXEC <execvy@gmail.com>
Signed-off-by: Eval EXEC <execvy@gmail.com>
Signed-off-by: Eval EXEC <execvy@gmail.com>
Signed-off-by: Eval EXEC <execvy@gmail.com>
Signed-off-by: Eval EXEC <execvy@gmail.com>
624171d
to
268b79b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces and supports Onion3 multiaddr for tentacle-multiaddr and adds
socks5
proxy support for tentacle dialing. It also allows tentacle to connect to a Tor server to reach an onion address.A breaking change introduced is:
Changing
to:
Adding an
Onion
variant to theTransportType
enum and implementingOnionTransport
.Allow
runtime::connect
to use asocks5
proxy for connecting to the target address.Add
runtime::connect_onion
to connect to a target address of theMultiaddr
type, rather than just aSocketAddr
, since tentacle cannot convert an onion address into aSocketAddr
.