-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(neuron-wallet): refactor node service #320
refactor(neuron-wallet): refactor node service #320
Conversation
Keith-CY
commented
May 11, 2019
•
edited
Loading
edited
- move ckb core into node service;
- add network switching on active network updating;
- check active network on initApp;
- add basic check on the network url, protocol required;
1. move ckb core into node service; 2. add network switching on active network updating; 3. check active network on initApp; 4. add basic check on the network url, protocol required;
// TODO: this function should be moved to somewhere syncing data | ||
syncConnectStatus() | ||
WalletChannel.start() | ||
const activeId = await NetworksController.service.activeId() | ||
if (!activeId) { | ||
await NetworksController.service.init() | ||
} | ||
if (!nodeService.core.node.url) { | ||
const id = await NetworksController.service.activeId() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not use service instead of controller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I means use service directly, not use controller.service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I means use service directly, not use
controller.service
The service was instantiated in the Controller, you mean instantiating one more here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or just create one somewhere, and controller also use that one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to remove controller in logic level, but we can do this later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense. I'm going to use dependency inject in the future.
…t.3 (#320) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore(deps): update dependency lerna to v7.4.2 (#314) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency jest-when to v3.6.0 (#313) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency jest-styled-components to v7.2.0 (#312) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/bi to v0.21.0-next.3 (#317) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency eslint-plugin-import to v2.29.0 (#309) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/codec to v0.21.0-next.3 (#319) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/hd to v0.21.0-next.3 (#322) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/common-scripts to v0.21.0-next.3 (#320) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/ckb-indexer to v0.21.0-next.3 (#318) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/config-manager to v0.21.0-next.3 (#321) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency react-i18next to v13.5.0 (#325) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @babel/core to v7.23.5 (#327) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency typescript to v5.3.3 * chore(deps): update dependency @types/enzyme to v3.10.18 (#328) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update reviewers of renovate (#330) * refactor: introduce tslib --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore(deps): update dependency lerna to v7.4.2 (#314) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency jest-when to v3.6.0 (#313) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency jest-styled-components to v7.2.0 (#312) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/bi to v0.21.0-next.3 (#317) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency eslint-plugin-import to v2.29.0 (#309) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/codec to v0.21.0-next.3 (#319) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/hd to v0.21.0-next.3 (#322) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/common-scripts to v0.21.0-next.3 (#320) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/ckb-indexer to v0.21.0-next.3 (#318) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/config-manager to v0.21.0-next.3 (#321) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency react-i18next to v13.5.0 (#325) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @babel/core to v7.23.5 (#327) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency typescript to v5.3.3 * chore(deps): update dependency @types/enzyme to v3.10.18 (#328) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update reviewers of renovate (#330) * chore(deps): update dependency @babel/core to v7.23.6 * chore(deps): update dependency eslint-plugin-import to v2.29.1 * refactor: introduce tslib * chore(deps): update dependency eslint to v8.56.0 * chore(deps): update react monorepo to v18 * chore(deps): update dependency wait-on to v7.2.0 * chore(deps): update dependency webpack to v5.89.0 * chore(deps): update dependency @types/styled-components to v5.1.34 * chore(deps): update node.js to v18.19.0 * refactor: update type declaration for react 18 * chore(deps): update peterjgrainger/action-create-branch action to v2.4.0 * chore(deps): update typescript-eslint monorepo to v5.62.0 * fix(deps): update dependency react-router-dom to v6.21.0 * fix(deps): update dependency sass to v1.69.5 * fix(deps): update dependency undici to v5.28.2 * chore(deps): update storybook monorepo to v7.6.6 (#342) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/checkout action to v4 (#349) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/github-script action to v7 (#350) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency react-i18next to v12.3.1 * chore(deps): update actions/setup-node action to v4 * chore(deps): update actions/stale action to v9 * chore(deps): update actions/upload-artifact action to v4 * chore(deps): update crazy-max/ghaction-import-gpg action to v6 (#355) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: rollback wait-on because it hangs in tcp connection --------- Signed-off-by: Chen Yu <keithwhisper@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore(deps): update dependency lerna to v7.4.2 (nervosnetwork#314) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency jest-when to v3.6.0 (nervosnetwork#313) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency jest-styled-components to v7.2.0 (nervosnetwork#312) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/bi to v0.21.0-next.3 (nervosnetwork#317) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency eslint-plugin-import to v2.29.0 (nervosnetwork#309) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/codec to v0.21.0-next.3 (nervosnetwork#319) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/hd to v0.21.0-next.3 (nervosnetwork#322) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/common-scripts to v0.21.0-next.3 (nervosnetwork#320) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/ckb-indexer to v0.21.0-next.3 (nervosnetwork#318) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/config-manager to v0.21.0-next.3 (nervosnetwork#321) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency react-i18next to v13.5.0 (nervosnetwork#325) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @babel/core to v7.23.5 (nervosnetwork#327) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency typescript to v5.3.3 * chore(deps): update dependency @types/enzyme to v3.10.18 (nervosnetwork#328) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update reviewers of renovate (nervosnetwork#330) * refactor: introduce tslib --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* chore(deps): update dependency lerna to v7.4.2 (nervosnetwork#314) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency jest-when to v3.6.0 (nervosnetwork#313) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency jest-styled-components to v7.2.0 (nervosnetwork#312) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/bi to v0.21.0-next.3 (nervosnetwork#317) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency eslint-plugin-import to v2.29.0 (nervosnetwork#309) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/codec to v0.21.0-next.3 (nervosnetwork#319) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/hd to v0.21.0-next.3 (nervosnetwork#322) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/common-scripts to v0.21.0-next.3 (nervosnetwork#320) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/ckb-indexer to v0.21.0-next.3 (nervosnetwork#318) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @ckb-lumos/config-manager to v0.21.0-next.3 (nervosnetwork#321) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency react-i18next to v13.5.0 (nervosnetwork#325) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @babel/core to v7.23.5 (nervosnetwork#327) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency typescript to v5.3.3 * chore(deps): update dependency @types/enzyme to v3.10.18 (nervosnetwork#328) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: update reviewers of renovate (nervosnetwork#330) * chore(deps): update dependency @babel/core to v7.23.6 * chore(deps): update dependency eslint-plugin-import to v2.29.1 * refactor: introduce tslib * chore(deps): update dependency eslint to v8.56.0 * chore(deps): update react monorepo to v18 * chore(deps): update dependency wait-on to v7.2.0 * chore(deps): update dependency webpack to v5.89.0 * chore(deps): update dependency @types/styled-components to v5.1.34 * chore(deps): update node.js to v18.19.0 * refactor: update type declaration for react 18 * chore(deps): update peterjgrainger/action-create-branch action to v2.4.0 * chore(deps): update typescript-eslint monorepo to v5.62.0 * fix(deps): update dependency react-router-dom to v6.21.0 * fix(deps): update dependency sass to v1.69.5 * fix(deps): update dependency undici to v5.28.2 * chore(deps): update storybook monorepo to v7.6.6 (nervosnetwork#342) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/checkout action to v4 (nervosnetwork#349) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update actions/github-script action to v7 (nervosnetwork#350) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency react-i18next to v12.3.1 * chore(deps): update actions/setup-node action to v4 * chore(deps): update actions/stale action to v9 * chore(deps): update actions/upload-artifact action to v4 * chore(deps): update crazy-max/ghaction-import-gpg action to v6 (nervosnetwork#355) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: rollback wait-on because it hangs in tcp connection --------- Signed-off-by: Chen Yu <keithwhisper@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>