-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: refactor sign method to allow unidentified lock scripts #2978
refactor: refactor sign method to allow unidentified lock scripts #2978
Conversation
The sign method is refactored to allow unidentified lock scripts while skipped lock scripts are prevented outside the sign method Notice that skipped lock scripts validation is not adopted when offline-sign a multisig transaction because it's explictly thrown when no private key is found. It may be intended.
a6454a3
to
7abc5ba
Compare
I guess the offline sign will throw an exception because the input is out of Neuron's control. But other transactions' input is created by Neuron, so the inputs's private key can be found in the wallet. |
In terms of functionality, I think a partial-signed transaction should be allowed for offline sign because it is allowed in "online" sign |
My bad, it should be "Notice that skipped lock scripts validation is not adopted when |
97aacd8
to
d957b29
Compare
The sign method is refactored to allow unidentified lock scripts
while skipped lock scripts are prevented outside the sign method
Notice that skipped lock scripts validation is not adopted when
a multisig transaction because it's explictly thrown
when no private key is found. It may be intended.