Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor sign method to allow unidentified lock scripts #2978

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

Keith-CY
Copy link
Collaborator

@Keith-CY Keith-CY commented Dec 8, 2023

The sign method is refactored to allow unidentified lock scripts
while skipped lock scripts are prevented outside the sign method

Notice that skipped lock scripts validation is not adopted when
a multisig transaction because it's explictly thrown
when no private key is found. It may be intended.

The sign method is refactored to allow unidentified lock scripts
while skipped lock scripts are prevented outside the sign method

Notice that skipped lock scripts validation is not adopted when
offline-sign a multisig transaction because it's explictly thrown
when no private key is found. It may be intended.
@yanguoyu
Copy link
Collaborator

yanguoyu commented Dec 8, 2023

I guess the offline sign will throw an exception because the input is out of Neuron's control. But other transactions' input is created by Neuron, so the inputs's private key can be found in the wallet.

@Keith-CY
Copy link
Collaborator Author

Keith-CY commented Dec 8, 2023

I guess the offline sign will throw an exception because the input is out of Neuron's control. But other transactions' input is created by Neuron, so the inputs's private key can be found in the wallet.

In terms of functionality, I think a partial-signed transaction should be allowed for offline sign because it is allowed in "online" sign

@Keith-CY
Copy link
Collaborator Author

Keith-CY commented Dec 8, 2023

I guess the offline sign will throw an exception because the input is out of Neuron's control. But other transactions' input is created by Neuron, so the inputs's private key can be found in the wallet.

My bad, it should be "Notice that skipped lock scripts validation is not adopted when
offline-sign sign a multisig transaction because it's explictly thrown
when no private key is found. It may be intended."

@Keith-CY Keith-CY merged commit b36e1cb into alpha/skip-unidentified-inputs Dec 12, 2023
21 checks passed
@Keith-CY Keith-CY deleted the refactor-sign-function branch December 12, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants