chore: optimize CKB insufficient error msg #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
=======================================
Coverage 42.07% 42.07%
=======================================
Files 22 22
Lines 1925 1925
Branches 48 48
=======================================
Hits 810 810
Misses 1115 1115 ☔ View full report in Codecov by Sentry. |
ghost
approved these changes
Dec 17, 2021
ghost
merged commit
cryptowen
pushed a commit
that referenced
this pull request
Jan 17, 2022
* feat: monitor and control asset security (#233) * feat: update white list generator * chore: refact price util * feat: impl switch and bot * update node version * chore: upgrade packages to support new ckb address (#234) * doc: update verifier guide (#237) * chore: add mannet config example (#238) * chore: update dev-deploy via docker * fix: version api * refactor: cast ethereum bridge log recipient address to new version (#243) * refactor: cast ethereum bridge log recipient address to new version * chore: update node require version * chore: fix ci * refactor: reconc check recipient with lockscript rather than address * workaround to generate full address * refactor: keep short address for now (#245) * refactor: cast ethereum bridge log recipient address to new version * chore: update node require version * chore: fix ci * refactor: reconc check recipient with lockscript rather than address * chore: node engines * rollback * chore: bump version * v0.0.13 * fix: ckb addr check in verifier (#250) * fix: ckb addr check in verifier * fix: ci node version * remove empty test file * feat: add readonly mode for watcher (#251) * fix: price function for USDT (#252) * chore: bump version * v0.0.14 * fix: compatible with invalid address (#253) * chore: bump version * v0.0.15 * Add Cardano to README.md (#254) * tests: add stress test script (#255) * test: add stress bridge test * chore * eth nonce * update * feat: integrate ui into dev-docker (#249) 1. integrate pw_lock 2. integrate force-bridge-ui 3. devnet-asset-white-list * feat: add watcher rpc api for bridge nervos to xchain (#259) * feat: watcher rpc api for bridge nervos to xchain * chore: fmt * doc: add change log (#257) * fix: version api of verifier (#260) * chore: optimize CKB insufficient error msg (#262) * chore: optimize CKB insufficient error msg * chore: make diff more accurate * refactor: rm watcher rpc api of nervos bridge to ethereum (#264) * chore: bump version to v0.0.16 * v0.0.16 * chore: bsc compatability support (#269) * chore: optimize testnetDocker (#271) * chore: update testnetDocker * chore: run testnet-docker:generate in docker * chore: run testnet-docker:generate in docker * update use-docker.md * update confirmNumber * chore: fmt * chore: bump version to v0.0.17 * v0.0.17 * feat: add cardano docker basic_testnet, with the 'force-bridge' cardano-wallet * feat: add cardano-single-address-wallet-client * feat: add AdaDb * feat: add ChainType.CARDANO, and AdaAsset * feat: AdaHandler + AdaConfig + AdaChain * feat: AdaSigner * feat: Add 'cardano lock' command to app-cli * Add XChainNetwork Cardano, and AdaDb in rpc-server * WIP Hack: increase BlockSync height * WIP Hack: Dont check bridgeFee for cardano * WIP Hack: remove bridge fee and EthAsset from transferDbRecordToResponse * WIP: Add cardano-integ, reusing ethereum integ code Note: this breaks integration.ts tests * add cardano-test to Makefile and cardano-integration-ci * WIP Hack: comment stress-test code as it fails to compile Co-authored-by: mkxbl <33241113+mkxbl@users.noreply.github.com> Co-authored-by: mkxbl <vyclzn@gmail.com> Co-authored-by: Divam Narula <dfordivam@protonmail.com> Co-authored-by: 杨炳新 <pygman@aliyun.com> Co-authored-by: Divam <dfordivam@gmail.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.