Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cross chain hub e2e test #275

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix cross chain hub e2e test #275

merged 1 commit into from
Oct 22, 2024

Conversation

doitian
Copy link
Member

@doitian doitian commented Oct 22, 2024

Remove steps 16~18, which closes the ln channel.

Reasons to remove these steps:

  1. The channel is opened in setup-lnd.sh. If we do need to test this,
    we should also open the lightning channel in bruno.
  2. It is not our concern that lnd can successfully close a channel.
  3. The implementation have bugs and fixing them is time consuming.
    1. Closing a channel is async in lnd, and we should block the test until
      the response stream closes, otherwise it is not to assert that we
      have closed the channel successfully.
    2. Closing a channel in lnd requires generating btc blocks so we
      need to call bitcoind rpc as well.

Remove steps 16~18, which closes the ln channel.

Reasons to remove these steps:

1. The channel is opened in `setup-lnd.sh`. If we do need to test this,
   we should also open the lightning channel in bruno.
2. It is not our concern that lnd can successfully close a channel.
3. The implementation have bugs and fixing them is time consuming.
    1. Closing a channel is async in lnd, and we should block the test until
       the response stream closes, otherwise it is not to assert that we
       have closed the channel successfully.
    2. Closing a channel in lnd requires generating btc blocks so we
       need to call bitcoind rpc as well.
@doitian doitian requested a review from contrun October 22, 2024 11:07
@contrun contrun merged commit 7e49685 into main Oct 22, 2024
32 checks passed
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.64%. Comparing base (e7109ca) to head (0a442b1).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
+ Coverage   45.10%   50.64%   +5.54%     
==========================================
  Files          44       44              
  Lines       27460    32425    +4965     
==========================================
+ Hits        12385    16423    +4038     
- Misses      15075    16002     +927     
Flag Coverage Δ
unittests 50.64% <ø> (+5.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chenyukang chenyukang deleted the fix-cch-e2e branch November 18, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants