Skip to content

Add Fiber lock script integration regression#81

Open
Xcodes-chain wants to merge 49 commits into
mainfrom
codex/fiber-lock-integration-regression
Open

Add Fiber lock script integration regression#81
Xcodes-chain wants to merge 49 commits into
mainfrom
codex/fiber-lock-integration-regression

Conversation

@Xcodes-chain

Copy link
Copy Markdown
Collaborator

Summary

Adds a focused Fiber devnet regression suite for the lock scripts used by channels.

  • Adds test_cases/fiber/devnet/lock_scripts with deployment availability checks for FundingLock, CommitmentLock, and their ckb-auth deps.
  • Covers the deployed-script main path: open channel, verify the funding cell uses FundingLock, force close, verify CommitmentLock output, generate the delay epoch, and confirm commitment cells settle.
  • Adds a dedicated fiber_lock_scripts_test Makefile target and a CI job in fiber.yml.
  • Fixes test.sh so pytest import/exit failures are not reported as passed, and makes local runs tolerate a missing GITHUB_STEP_SUMMARY.
  • Fixes an RPC logging formatting bug that masked original RPC errors.

Validation

  • venv/bin/python -m black --check test_cases/fiber/devnet/lock_scripts/test_lock_script_deployment_regression.py framework/rpc.py
  • venv/bin/python -m pytest --collect-only -q test_cases/fiber/devnet/lock_scripts
  • PYTHON=venv/bin/python make fiber_lock_scripts_test (2 passed)

Notes

The worktree had pre-existing local changes and runtime artifacts before this PR. This branch only includes the lock-script regression, CI target/job, and runner/logging fixes needed for that regression.

gpBlockchain and others added 30 commits May 11, 2026 09:59
* chore: bump fiber to 0.9.0-rc1

Agent-Logs-Url: https://github.com/nervosnetwork/fiber-py-integration-test/sessions/d78725f4-2d0c-4cca-adf5-b24d588597b1

Co-authored-by: gpBlockchain <32102187+gpBlockchain@users.noreply.github.com>

* chore: keep 0.8.0 compatibility download

Agent-Logs-Url: https://github.com/nervosnetwork/fiber-py-integration-test/sessions/d78725f4-2d0c-4cca-adf5-b24d588597b1

Co-authored-by: gpBlockchain <32102187+gpBlockchain@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/nervosnetwork/fiber-py-integration-test/sessions/1c3b70e3-796c-46c5-98c6-2ad82d88b72d

Co-authored-by: gpBlockchain <32102187+gpBlockchain@users.noreply.github.com>
Add v0.9.0 migration and install script tests
* Update test_close_script.py

* Update test_force.py
* Update test_max_tlc_number_in_flight_debug.py

* Update test_max_tlc_value_in_flight.py

* Update test_max_tlc_value_in_flight.py

* Update test_max_tlc_value_in_flight.py
Xcodes-chain and others added 19 commits June 11, 2026 17:40
* test(security): add regression tests for 21 security PRs on v0.9.0-rc3

New black-box / integration tests under test_cases/fiber/devnet/security/:
- test_cli_security_regressions.py  (#1414 auth-token, #1413 history redaction, #1389 store perms)
- test_amp_hash_algorithm_fresh.py  (#1411 AMP success path per hash algorithm, fresh invoice)
- test_watchtower_task_survives_rpc_error.py  (#1397 event task survives watchtower RPC error)

Verified on fnn v0.9.0-rc3 (4255b04).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* test(security): add rpc error redaction regression

* ci: run security regression tests

* style: format security regression tests

* test: address security review feedback

* narrow pytest.raises(Exception) to TimeoutError in watchtower test

* fix: raise timeout errors from wait helpers

* test(security): fix review findings in security regression tests

- config: align watchtower_rpc_url asserts with new wait_tx_pool timeout message (HIGH-1)
- watchtower: redesign survives-RPC-error test to be discriminating, add log-based negative control, switch fixed sleeps to interval-based polling (HIGH-2)
- rpc redaction: drop false-positive malformed-param case, focus on well-formed preimage path (MEDIUM-1)
- cli: robust private-mode check (mode & 0o077 == 0) and skipif when fnn-cli missing (MEDIUM-2, LOW-2)
- move AMP hash-algorithm test to send_payment/atomic_mpp (LOW-1)

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@Xcodes-chain
Xcodes-chain force-pushed the codex/fiber-lock-integration-regression branch 2 times, most recently from e449818 to e52eaba Compare July 21, 2026 02:29
@Xcodes-chain
Xcodes-chain marked this pull request as ready for review July 21, 2026 02:30
@Xcodes-chain
Xcodes-chain force-pushed the codex/fiber-lock-integration-regression branch 2 times, most recently from 4691b98 to ac53535 Compare July 22, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants