Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: simplify the code #4666

Merged
merged 1 commit into from
Sep 26, 2024
Merged

chore: simplify the code #4666

merged 1 commit into from
Sep 26, 2024

Conversation

driftluo
Copy link
Collaborator

What problem does this PR solve?

Simplify the code：

  1. use IF NOT EXISTS to create SQL
  2. early return on or judgment

Check List

Tests

  • Unit test
  • Integration test

Release note

None: Exclude this PR from the release note.

@driftluo driftluo requested a review from a team as a code owner September 26, 2024 06:29
@driftluo driftluo requested review from zhangsoledad and removed request for a team September 26, 2024 06:29
@driftluo driftluo requested a review from eval-exec September 26, 2024 06:34
eval-exec
eval-exec previously approved these changes Sep 26, 2024
View reviewed changes
@driftluo driftluo requested a review from eval-exec September 26, 2024 06:51
@driftluo driftluo added this pull request to the merge queue Sep 26, 2024
Merged via the queue into nervosnetwork:develop with commit 7e574a8 Sep 26, 2024
32 checks passed
@driftluo driftluo deleted the simplify-code branch September 26, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad zhangsoledad is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@driftluo @eval-exec