Skip to content

Add include_tx_pool: Option<bool> param to ChainRpcImpl::get_live_cell'#4454

Merged
quake merged 2 commits intonervosnetwork:developfrom
eval-exec:exec/get_live_cell_include_tx_pool
Jun 7, 2024
Merged

Add include_tx_pool: Option<bool> param to ChainRpcImpl::get_live_cell'#4454
quake merged 2 commits intonervosnetwork:developfrom
eval-exec:exec/get_live_cell_include_tx_pool

Conversation

@eval-exec
Copy link
Collaborator

What problem does this PR solve?

Related changes

  • Add include_tx_pool: bool param to ChainRpcImpl::get_live_cell RPC

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec force-pushed the exec/get_live_cell_include_tx_pool branch 2 times, most recently from e8b588d to bb67755 Compare May 11, 2024 01:29
@eval-exec eval-exec marked this pull request as ready for review May 11, 2024 01:38
@eval-exec eval-exec requested a review from a team as a code owner May 11, 2024 01:38
@eval-exec eval-exec requested review from chenyukang, doitian, quake and zhangsoledad and removed request for a team May 11, 2024 01:38
@eval-exec eval-exec added the b:rpc Break RPC interface label May 11, 2024
@eval-exec eval-exec changed the title Add include_tx_pool: bool param to ChainRpcImpl::get_live_cell' Add include_tx_pool: Option<bool> param to ChainRpcImpl::get_live_cell' May 11, 2024
@eval-exec eval-exec marked this pull request as draft May 11, 2024 02:44
@eval-exec eval-exec force-pushed the exec/get_live_cell_include_tx_pool branch from bb67755 to 7a9af4b Compare May 11, 2024 05:01
@eval-exec eval-exec marked this pull request as ready for review May 11, 2024 05:01
@quake quake merged commit 5872af1 into nervosnetwork:develop Jun 7, 2024
@doitian
Copy link
Member

doitian commented Jun 11, 2024

@eval-exec please backport to rc/v0.117.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b:rpc Break RPC interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants