Skip to content

Backport #4273#4288

Merged
doitian merged 8 commits intonervosnetwork:rc/v0.113.xfrom
eval-exec:exec/get_pool_tx_detail_info_rc
Jan 2, 2024
Merged

Backport #4273#4288
doitian merged 8 commits intonervosnetwork:rc/v0.113.xfrom
eval-exec:exec/get_pool_tx_detail_info_rc

Conversation

@eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Jan 2, 2024 •
edited
Loading

Backport #4273

What problem does this PR solve?

This PR updated the type of struct PoolTxDetailInfo::score_sortkey from String to struct AncestorsScoreSortKey. This change makes it easier to parse and work with.

What's Changed:

Related changes

  • Change score_sortkey's type from String to struct AncestorsScoreSortKey

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec requested a review from a team as a code owner January 2, 2024 01:56
@eval-exec eval-exec requested a review from quake January 2, 2024 01:56
@eval-exec eval-exec marked this pull request as draft January 2, 2024 01:57
@eval-exec eval-exec force-pushed the exec/get_pool_tx_detail_info_rc branch from e4bd5b7 to 6fcc9aa Compare January 2, 2024 02:02
@eval-exec eval-exec requested a review from doitian January 2, 2024 02:02
@eval-exec eval-exec assigned eval-exec and unassigned eval-exec Jan 2, 2024
@eval-exec eval-exec marked this pull request as ready for review January 2, 2024 02:03
quake
quake previously approved these changes Jan 2, 2024
View reviewed changes
@eval-exec eval-exec marked this pull request as draft January 2, 2024 02:16
@eval-exec eval-exec force-pushed the exec/get_pool_tx_detail_info_rc branch from 6fcc9aa to 486b871 Compare January 2, 2024 02:25
@eval-exec eval-exec marked this pull request as ready for review January 2, 2024 02:25
@eval-exec
Copy link
Collaborator Author

eval-exec commented Jan 2, 2024 •
edited
Loading

I create this PR by these steps:

git checkout rc/v0.113.x
git checkout -b exec/get_pool_tx_detail_info_rc
git cherry-pick 6a7718d72436a09acd94a922b51550bf9dfc4237^..66424d4022b32e6ed29002bc21de729220ea57a7
git push eval-exec HEAD -f

@eval-exec
Copy link
Collaborator Author

eval-exec commented Jan 2, 2024

@doitian I think this PR is ready for v0.113.0-rc3

@doitian doitian merged commit b409568 into nervosnetwork:rc/v0.113.x Jan 2, 2024
This was referenced Aug 1, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quake quake quake approved these changes

@doitian doitian Awaiting requested review from doitian

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eval-exec @quake @doitian