Add feature of Replace-by-fee for tx-pool#4108
Merged
zhangsoledad merged 63 commits intodevelopfrom Aug 18, 2023
Merged
Conversation
Tx pool Replace-by-fee
quake
approved these changes
Aug 18, 2023
eval-exec
approved these changes
Aug 18, 2023
Closed
4 tasks
3 tasks
This was referenced May 30, 2024
This was referenced Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code review is in #4079
What problem does this PR solve?
Add feature of Replace-by-fee for
tx-pool.Fixes #3734
Problem Summary:
What is changed and how it works?
What's Changed:
This RBF feature enables users to replace a transaction with a higher fee rate when pending in
tx-pool, which is useful when the transaction is stuck in thetx-pool:min_rbf_rateinckb.tomlwith default value1500, which means the minimum extra fee rate for RBF, the unit isshannons/KBfeeandmin_replace_feeinget_transaction, which means the the minimal fee need to pay for RBF for a specific transactionmin_replace_fee = sum(replaced_tx_fee) + (min_rbf_rate * size)tx-pooland with the statusRejected.Related changes
owner/repo:Check List
Tests
Side effects
Release note