Skip to content

rpc(ChainRpc): Add only_committed param for get_transaction#3963

Merged
zhangsoledad merged 2 commits intonervosnetwork:developfrom
eval-exec:exec/get_transaction-only_committed
May 4, 2023
Merged

rpc(ChainRpc): Add only_committed param for get_transaction#3963
zhangsoledad merged 2 commits intonervosnetwork:developfrom
eval-exec:exec/get_transaction-only_committed

Conversation

@eval-exec
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #3962
What's Changed:

Related changes

  • Add only_committed param for get_transaction RPC.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec added the t:enhancement Type: Feature, refactoring. label Apr 27, 2023
@eval-exec eval-exec force-pushed the exec/get_transaction-only_committed branch 3 times, most recently from 319640d to 3d7539b Compare May 3, 2023 11:29
@eval-exec eval-exec force-pushed the exec/get_transaction-only_committed branch from 3d7539b to 4145095 Compare May 3, 2023 11:33
@eval-exec eval-exec marked this pull request as ready for review May 3, 2023 11:34
@eval-exec eval-exec requested a review from a team as a code owner May 3, 2023 11:34
@eval-exec eval-exec requested review from zhangsoledad and removed request for a team May 3, 2023 11:34
@eval-exec eval-exec self-assigned this May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:enhancement Type: Feature, refactoring.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Introduce an rpc to query only confirmed transactions

2 participants